fix: resolve all test failures and type errors#6
Open
stooit wants to merge 1 commit into
Open
Conversation
…packages - Fix auth middleware case-sensitivity bug (normalize HTTP method comparison) - Rename User type fields (userName→username, emailAddress→email) for consistency - Add missing badRequest import in users route handler - Implement paginate utility function in shared package - Add bun-types to tsconfig for proper type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests (22 tests now pass) and eliminates all TypeScript type errors across the
apiandsharedpackages.Changes
packages/api/src/middleware/auth.ts) — Fixed case-sensitivity bug in HTTP method comparison. The middleware was comparing request methods without normalizing case, causing POST requests to be incorrectly blocked by auth.packages/shared/src/types.ts) — RenameduserName→usernameandemailAddress→emailto match the field names used throughout the API routes and tests.packages/api/src/routes/users.ts) — Added missingbadRequestimport from the errors library.packages/shared/src/utils/pagination.ts) — Implemented thepaginatefunction (was previously a stub throwing "not implemented").tsconfig.json) — Addedbun-typesto compiler options for properprocesstype resolution.Verification
Assumptions